Re: [PATCH v4 11/16] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init

[Juergen Gross]

On 27.10.22 14:18, Borislav Petkov wrote:
> On Tue, Oct 04, 2022 at 10:10:18AM +0200, Juergen Gross wrote:
> > diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c
> > index 49b60a427fc9..330aa412be63 100644
> > --- a/arch/x86/kernel/cpu/cacheinfo.c
> > +++ b/arch/x86/kernel/cpu/cacheinfo.c
> > @@ -1137,3 +1137,10 @@ void cache_cpu_init(void)
> >   	cache_enable();
> >   	local_irq_restore(flags);
> >   }
> > +
> > +bool cache_aps_delayed_init;
>
> Why isn't that static and only the accessors set it or clear it?
>
> > +void set_cache_aps_delayed_init(void)
> > +{
> > +	cache_aps_delayed_init = true;
> > +}
>
> Otherwise, there's no point for this thing.

Hmm, right.

I'll add a get_cache_aps_delayed_init() accessor.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature