Re: [PATCH v2] scripts: checkpatch: allow "case" macros

From: Joe Perches
Date: Thu Oct 27 2022 - 10:28:20 EST


On Thu, 2022-10-27 at 15:43 +0200, Stanislaw Gruszka wrote:
> Do not report errors like below:
>
> ./scripts/checkpatch.pl -f drivers/net/wireless/ath/ath10k/wmi.h
>
> ERROR: Macros with complex values should be enclosed in parentheses
> +#define C2S(x) case x: return #x
>
> since many "case ..." macros are already used by some in-kernel drivers.
>
> Signed-off-by: Stanislaw Gruszka <stf_xl@xxxxx>

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1e5e66ae5a52..4b888b1313d5 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5901,6 +5901,7 @@ sub process {
> $dstat !~ /$exceptions/ &&
> $dstat !~ /^\.$Ident\s*=/ && # .foo =
> $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ && # stringification #foo
> + $dstat !~ /^case\b/ && # case ...
> $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
> $dstat !~ /^while\s*$Constant\s*$Constant\s*$/ && # while (...) {...}
> $dstat !~ /^for\s*$Constant$/ && # for (...)