Re: [PATCH v5 2/6] staging: vt6655: refactor code in s_uGetRTSCTSDuration

From: Greg KH
Date: Thu Oct 27 2022 - 10:50:36 EST


On Thu, Oct 27, 2022 at 02:09:52PM +0100, Tanju Brunostar wrote:
> On Thu, Oct 27, 2022 at 10:19 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Oct 27, 2022 at 08:59:04AM +0000, Tanjuate Brunostar wrote:
> > > refactor long lines of code in the function: s_uGetRTSCTSDuration
> >
> > Please write full sentences.
> >
> > Also please read the in-kernel documentation for how to write good
> > changelog text. Specifically look at the section entitled "The
> > canonical patch format" in the kernel file,
> > Documentation/SubmittingPatches for a description of how to do this
> > properly.
> >
> > Do this for all of the patches in this series.
> >
> > thanks,
> >
> > greg k-h
>
> Hello Greg
> the file does not exist in Documentations

$ cat Documentation/SubmittingPatches
This file has moved to process/submitting-patches.rst

> Also, I had to make the sentences shorter because you said changelog
> text was too long.

You had too long of a single line. Wrap your lines.

Look at all of the changelogs for the driver itself as examples.

thanks,

greg k-h