Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()

From: Justin Chen
Date: Thu Oct 27 2022 - 12:50:52 EST


On Wed, Oct 26, 2022 at 3:45 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Acked-by: Justin Chen <justinpopo6@xxxxxxxxx>

> ---
> drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
> index 2cb3779fcdf8..fbf454b206f2 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb.c
> @@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
> priv->suspend_clk = NULL;
> }
>
> - priv->wake_irq = platform_get_irq_byname(pdev, "wake");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
> if (priv->wake_irq < 0)
> - priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
> if (priv->wake_irq >= 0) {
> err = devm_request_irq(dev, priv->wake_irq,
> brcm_usb_phy_wake_isr, 0,
> --
> 2.25.1
>