Re: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable

From: Jakub Kicinski
Date: Thu Oct 27 2022 - 14:03:23 EST


On Wed, 26 Oct 2022 20:59:10 +0800 Cai Huoqing wrote:
> Subject: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable

Please put [PATCH net-next] or [PATCH -next] in the subject,
to make the patch sorting easier for maintainers.

> The print cmd code is in hex, so using hex cmd code intead of
> decimal is easy to check the value with print info.

> - HINIC_PORT_CMD_SET_AUTONEG = 219,
> -
> - HINIC_PORT_CMD_GET_STD_SFP_INFO = 240,
> -
> - HINIC_PORT_CMD_SET_LRO_TIMER = 244,
> -
> - HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 249,
> -
> - HINIC_PORT_CMD_GET_SFP_ABS = 251,
> + HINIC_PORT_CMD_GET_SFP_ABS = 0xFB,

This deletes some entries. Please don't mix changes with mechanical
conversions.