Re: [PATCH v2 1/2] ARM: nspire: Use syscon-reboot to handle restart

[Andrew Davis]

On 10/26/22 3:17 PM, Krzysztof Kozlowski wrote:
> On 26/10/2022 12:13, Andrew Davis wrote:
> > Writing this bit can be handled by the syscon-reboot driver. Add the
> > info to DT and remove the machine_desc version.
> >
> > Signed-off-by: Andrew Davis <afd@xxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/nspire.dtsi |  7 +++++++
>
> DTS cannot go with code.
>
> Additionally, this breaks people's filtering as there is no "dts" prefix
> in the subject.
>
> >   arch/arm/mach-nspire/Kconfig  |  2 ++
> >   arch/arm/mach-nspire/mmio.h   |  3 ---
> >   arch/arm/mach-nspire/nspire.c | 10 ----------
> >   4 files changed, 9 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi
> > index bb240e6a3a6f..6357b803521e 100644
> > --- a/arch/arm/boot/dts/nspire.dtsi
> > +++ b/arch/arm/boot/dts/nspire.dtsi
> > @@ -172,7 +172,14 @@ rtc: rtc@90090000 {
> >   			};
> >   
> >   			misc: misc@900a0000 {
> > +				compatible = "syscon", "simple-mfd";
>
> These are not allowed on their own (need specific compatible) and you
> should have warnings when running dtbs_check.

Ah, my bad, must have gotten lost in the other existing warnings.
Sent v3 with the above fixes, and tried to remove some existing warnings.

Thanks,
Andrew

> Best regards,
> Krzysztof