Re: [PATCH v3 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings

From: Krzysztof Kozlowski
Date: Thu Oct 27 2022 - 15:35:50 EST


On 27/10/2022 14:24, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2022-10-27 08:54:51)
>> On 26/10/2022 15:04, Melody Olvera wrote:
>>> +description: |
>>> + Qualcomm global clock control module which supports the clocks, resets and
>>> + power domains on QDU1000 and QRU1000
>>> +
>>> + See also:
>>> + - include/dt-bindings/clock/qcom,gcc-qdu1000.h
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - const: qcom,gcc-qdu1000
>>> + - const: syscon
>>> +
>>> + clocks:
>>> + items:
>>> + - description: Board XO source
>>> + - description: Sleep clock source
>>> + - description: PCIE 0 Pipe clock source
>>> + - description: PCIE 0 Phy Auxiliary clock source
>>> + - description: USB3 Phy wrapper pipe clock source
>>> + minItems: 2
>>
>> Why the clocks are optional?
>
> They should not be optional. They're always there.

Just to be sure - I refer to last three clocks here as indicated by
minItems:2.

DTS does not define them, so something here is not complete or correct.

Best regards,
Krzysztof