Re: [PATCHv2 1/1] dt-bindings: net: snps,dwmac: Document queue config subnodes
From: Krzysztof Kozlowski
Date: Thu Oct 27 2022 - 15:50:53 EST
On 27/10/2022 12:31, Sebastian Reichel wrote:
> The queue configuration is referenced by snps,mtl-rx-config and
> snps,mtl-tx-config. Some in-tree DTs and the example put the
> referenced config nodes directly beneath the root node, but
> most in-tree DTs put it as child node of the dwmac node.
>
> This adds proper description for this setup, which has the
> advantage of validating the queue configuration node content.
>
> The example is also updated to use the sub-node style, incl.
> the axi bus configuration node, which got the same treatment
> as the queues config in 5361660af6d3 ("dt-bindings: net: snps,dwmac:
> Document stmmac-axi-config subnode").
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> Changes since PATCHv1:
> * https://lore.kernel.org/all/20221021171055.85888-1-sebastian.reichel@xxxxxxxxxxxxx/
> * add logic to make booleans that are actually enums mutually exclusive
> * fix type of "snps,send_slope", "snps,idle_slope", "snps,high_credit" and "snps,low_credit"
> * add missing 'additionalProperties: false' in rx-queues-config -> "^queue[0-9]$"
> * add missing 'additionalProperties: false' in tx-queues-config -> "^queue[0-9]$"
> * update example to follow the sub-node style
Uh, this grew big... Thanks for fixing it.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof