Re: [PATCH v3 05/17] ufs: core: mcq: Introduce Multi Circular Queue

[Bart Van Assche]

On 10/20/22 11:03, Asutosh Das wrote:
> Introduce multi-circular queue (MCQ) which has been added
> in UFSHC v4.0 standard in addition to the Single Doorbell mode.
> The MCQ mode supports multiple submission and completion queues.
> Add support to configure the number of queues.

Introduce -> Add support for?

> +static int ufshcd_alloc_mcq(struct ufs_hba *hba)
> +{
> +	int ret;
> +
> +	ret = ufshcd_mcq_init(hba);
> +
> +	return ret;
> +}

Although a later patch will modify the above function, please change the 
function body into the following in this patch:

        return ufshcd_mcq_init(hba);

Otherwise this patch looks good to me.

Thanks,

Bart.