Re: [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode

From: Bart Van Assche
Date: Thu Oct 27 2022 - 17:38:39 EST


On 10/20/22 11:03, Asutosh Das wrote:
int ufshcd_mcq_init(struct ufs_hba *hba)
{
- int ret;
+ int ret, i;
+ struct ufs_hw_queue *hwq;

Although this is not a strict rule, most kernel developers these days order declarations from longer to shorter ("reverse Christmas tree").

+ /* The very first HW queue is to serve device command */

is to serve -> serves
command -> commands

Otherwise this patch looks good to me.

Thanks,

Bart.