Re: [PATCH v3 09/17] ufs: core: mcq: Configure operation and runtime interface

From: Bart Van Assche
Date: Thu Oct 27 2022 - 18:02:07 EST


On 10/20/22 11:03, Asutosh Das wrote:
+/**
+ * ufshcd_mcq_config_mac - Set the #Max Activ Cmds.
+ * @hba - per adpater instance

adpater -> adapter

+ * @max_active_cmds - maximum # of active commands to the device at any time.
+ *
+ * The controller wouldn't send more than the max_active_cmds to the device at
+ * any time.
+ */

wouldn't -> won't

+#define MCQ_CFG_n(r, i) \
+ ((r) + MCQ_QCFG_SIZE * (i))

No need to spread this macro over two lines.

Otherwise this patch looks good to me.

Bart.