Re: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema

[Krzysztof Kozlowski]

On 26/10/2022 23:01, Joy Zou wrote:
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: 2022年10月26日 22:59
>> To: Joy Zou <joy.zou@xxxxxxx>; vkoul@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
>> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
>> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx
>> Cc: S.J. Wang <shengjiu.wang@xxxxxxx>; martink@xxxxxxxxx;
>> dev@xxxxxxxxxx; alexander.stein@xxxxxxxxxxxxxxx; Peng Fan
>> <peng.fan@xxxxxxx>; david@xxxxxxx; aford173@xxxxxxxxx; Hongxing Zhu
>> <hongxing.zhu@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
>> dmaengine@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma
>> to DT schema
>>
>> Caution: EXT Email
>>
>> On 25/10/2022 04:36, Joy Zou wrote:
>>> Convert the i.MX SDMA binding to DT schema format using json-schema.
>>>
>>> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma,
>>> fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to
>>> delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and
>>> fsl,imx6sl-sdma are added. The original binding don't list all compatible used.
>>>
>>> In addition, add new peripheral types HDMI Audio.
>>>
>>> Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
>>> ---
>>> Changes in v8:
>>> add the dma-controller quotes.
>>
>> Why adding quotes?
> I refer to your comments in patch v7/1. The comment as follow:
> +maintainers:
> +  - Joy Zou <joy.zou@xxxxxxx>
> +
> You need to reference dma-controller.yaml schema.

Yes, you need to reference dma-controller.yaml. Nothing about quotes.
Reference is "$ref: .....yaml"


> +properties:
> +  compatible:
> +    one of:
> I misunderstand that add the dma-controller.yaml quotes. 

There was nothing about quotes - ".

> So I am a little confused. Now, I see.
> should I add dma-common.yaml quotes but not the dma-controller?

Just drop "

https://en.wikipedia.org/wiki/Quotation_mark

Best regards,
Krzysztof