Re: [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

From: Chao Yu
Date: Thu Oct 27 2022 - 23:39:02 EST


On 2022/10/28 11:17, Jaegeuk Kim wrote:
On 10/28, Chao Yu wrote:
On 2022/10/28 10:33, Yangtao Li wrote:
It won't pollute global namespace since it's a static function just be used in f2fs/super.c...

emm, I think it would be nice to see the f2fs_record_error_work symbol
in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.

Oh, yes, let me update in original patch as well.

Chao,

It seems there're multiple bugs. Please apply this as well.

https://lore.kernel.org/linux-f2fs-devel/20221027180416.3786792-1-jaegeuk@xxxxxxxxxx/T/#u

Jaegeuk,

Thanks, let me merge all those patches and do the test.

Thanks,




Do you mind letting me merge these two patches into original patch?
since original patch is still in dev branch, rather than mainline.

Glad to see, if resend.

Thanks, :)


I guess it needs to stop ckpt thread as well...

agree, :)

Thanks,