Re: [PATCH v4 1/2] clocksource: loongson2_hpet: add hpet driver support

[Yinbo Zhu]

在 2022/10/26 下午10:20, Krzysztof Kozlowski 写道:
> On 25/10/2022 23:57, Yinbo Zhu wrote:
> > HPET (High Precision Event Timer) defines a new set of timers, which
> > are used by the operating system to schedule threads, interrupt the
> > kernel and interrupt the multimedia timer server. The operating
> > system can assign different timers to different applications. By
> > configuration, each timer can generate interrupt independently.
> >
> > The loongson2 HPET module includes a main count and three comparators
> > , all of which are 32 bits wide. Among the three comparators, only
>
> No blank line before coma.
You said that need blank line is need a blank space before comma?  I
will add it a blank space before comma.
> > one comparator supports periodic interrupt, all three comparators
> > support non periodic interrupts.
> >
> > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > ---
> > Change in v4:
> >                  1. Use common clock framework ops to gain apb clock.
> >                  2. This patch need rely on clock patch, which patchwork
> >                     link was "https://patchwork.kernel.org/project/linux-clk/list/?series=688892";.
>
> Link to lore.
>
> The point 2 should go to cover letter. It's easy to miss it.
>
> Best regards,
> Krzysztof