Re: [PATCH] Possible repeated word: 'very'

From: Bagas Sanjaya
Date: Fri Oct 28 2022 - 03:41:31 EST


On Fri, Oct 28, 2022 at 10:04:39AM +0300, UMWARI JOVIAL wrote:
> Reported By checkpatch.pl script
>
> WARNING: Possible repeated word: 'very'
>
> Repetition of the same word in one sentence same line
>
> Signed-off-by: UMWARI JOVIAL <umwarijovial@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index 090345bad223..30a0276b8b58 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> * If we turn on USE_RXTHREAD, then, no need for critical section.
> * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> *
> - * Must be very very cautious...
> + * Must be very cautious...
> *
> */
> struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)

NAK!

You send patch with the same content as [1], for which Greg already replied
as [2].

The code and its comments imply that calling r8712_alloc_xmitframe() must be
done with extreme caution, isn't it?

Thanks.

[1]: https://lore.kernel.org/lkml/20221028051420.GA30073@rdm/
[2]: https://lore.kernel.org/lkml/Y1tx8XjmR5QKV9lQ@xxxxxxxxx/
--
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature