Re: [PATCH RESEND v4] usb: core: stop USB enumeration if too many retries

From: Greg KH
Date: Fri Oct 28 2022 - 05:10:03 EST


On Fri, Oct 28, 2022 at 05:01:16PM +0800, Ray Chi wrote:
> When a broken USB accessory connects to a USB host, usbcore might
> keep doing enumeration retries. If the host has a watchdog mechanism,
> the kernel panic will happen on the host.
>
> This patch provides an attribute early_stop to limit the numbers of retries
> for each port of a hub. If a port was marked with early_stop attribute,
> unsuccessful connection attempts will fail quickly. In addition, if an
> early_stop port has failed to initialize, it will ignore all future
> connection events until early_stop attribute is clear.
>
> Signed-off-by: Ray Chi <raychi@xxxxxxxxxx>
> ---
> Documentation/ABI/testing/sysfs-bus-usb | 11 +++++
> drivers/usb/core/hub.c | 59 +++++++++++++++++++++++++
> drivers/usb/core/hub.h | 4 ++
> drivers/usb/core/port.c | 27 +++++++++++
> 4 files changed, 101 insertions(+)
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot