RE: [PATCH v2] staging: iio: frequency: ad9834: Use div64_ul instead of do_div

[Sa, Nuno]

> -----Original Message-----
> From: Deepak R Varma <drv@xxxxxxxxx>
> Sent: Friday, October 28, 2022 12:00 AM
> To: outreachy@xxxxxxxxxxxxxxx; Lars-Peter Clausen <lars@xxxxxxxxxx>;
> Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron
> <jic23@xxxxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>;
> linux-iio@xxxxxxxxxxxxxxx; linux-staging@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v2] staging: iio: frequency: ad9834: Use div64_ul instead of
> do_div
> 
> [External]
> 
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation. Issue identified using the
> coccicheck tool.
> 
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> ---

Clearly, I should have looked better and only reply to this one:

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>