Re: [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection

From: Mark Brown
Date: Fri Oct 28 2022 - 08:59:10 EST


On Fri, Oct 28, 2022 at 08:54:31PM +0800, Ajye Huang wrote:

> Yes, the original version I tried the implementation on audio machine
> driver, but one person gave me an idea for this dmic.c
> Do you think it is appropriate on dmic.c?
> If it isn't, I will add kcontrol into audio machine driver. thanks

It's definitely a better fit somewhere else - like I said in reply to
the DT binding it's really a mux that sits between the DMICs and the DAI
so that's probably where a generic version should be implemented.

Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Attachment: signature.asc
Description: PGP signature