Re: [PATCH v3 08/15] phy: qcom-qmp-pcie: add register init helper

[Vinod Koul]

On 28-10-22, 15:07, Johan Hovold wrote:
> On Fri, Oct 28, 2022 at 06:24:38PM +0530, Vinod Koul wrote:
> > On 21-10-22, 13:32, Johan Hovold wrote:
> 
> > > [...] This is not about keeping the
> > > diff small, this is about readability of the new helper function as I
> > > already told you.
> > > 
> > > And this is a *local* identifier, not some state member that needs a
> > > super descriptive name. And the rest of the driver used "tbl"
> > > consistently until your EP/RC mode patches for that matter.
> > 
> > I would disagree here... You can change tbls/tables but then it does not
> > help _this_ patch
> > 
> > Right thing would be to change tbls to tables first and then add init
> > helper... For a reviewer seeing an undocumented change and unnecessary
> > diff is not right..
> 
> I still think that it belongs in the patch adding the new helper
> because it is essentially only in that new function that the improved
> readability due to the shorter identifier matters (the earlier helpers
> where per table type).
>  
> > Pls split if you would still like the rename
> 
> But if you prefer I'll split it out in a preparatory patch.

That would be good thanks

-- 
~Vinod