Re: [PATCH 11/15] hdlcdrv: remove HDLCDRV_MAGIC

From: Bagas Sanjaya
Date: Fri Oct 28 2022 - 09:54:58 EST


On 10/27/22 05:43, наб wrote:
> We have largely moved away from this approach,
> and we have better debugging instrumentation nowadays: kill it
>

Same reply as [1].

> Additionally, ~half HDLCDRV_MAGIC checks just early-exit instead
> of noting the bug, so they're detrimental, if anything
>

"... instead of handling the magic number"?

Thanks.

[1]: https://lore.kernel.org/linux-doc/80c998ec-435f-158c-9b45-4e6844f7861b@xxxxxxxxx/

--
An old man doll... just what I always wanted! - Clara