Re: [PATCH] ACPI: processor_throttling: remove variable count

From: Rafael J. Wysocki
Date: Fri Oct 28 2022 - 13:05:32 EST


On Mon, Oct 24, 2022 at 3:33 PM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> Variable count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/acpi/processor_throttling.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index a822fe410dda..00d045e5f524 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -50,7 +50,7 @@ static int __acpi_processor_set_throttling(struct acpi_processor *pr,
>
> static int acpi_processor_update_tsd_coord(void)
> {
> - int count, count_target;
> + int count_target;
> int retval = 0;
> unsigned int i, j;
> cpumask_var_t covered_cpus;
> @@ -107,7 +107,6 @@ static int acpi_processor_update_tsd_coord(void)
>
> /* Validate the Domain info */
> count_target = pdomain->num_processors;
> - count = 1;
>
> for_each_possible_cpu(j) {
> if (i == j)
> @@ -140,7 +139,6 @@ static int acpi_processor_update_tsd_coord(void)
>
> cpumask_set_cpu(j, covered_cpus);
> cpumask_set_cpu(j, pthrottling->shared_cpu_map);
> - count++;
> }
> for_each_possible_cpu(j) {
> if (i == j)
> --

Applied as 6.2 material, thanks!