Re: [PATCH v5 2/2] dt-bindings: Document common device controller bindings

From: Krzysztof Kozlowski
Date: Fri Oct 28 2022 - 13:40:07 EST


On 27/10/2022 02:35, Oleksii Moisieiev wrote:
> On Wed, Oct 26, 2022 at 04:51:15PM -0500, Rob Herring wrote:
>> On Wed, 26 Oct 2022 17:51:27 +0000, Oleksii Moisieiev wrote:
>>> Introducing of the common device controller bindings for the controller
>>> provider and consumer devices. Those bindings are intended to allow
>>> divided system on chip into muliple domains, that can be used to
>>> configure hardware permissions.
>>>
>>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
>>> ---
>>> .../feature-domain-controller.yaml | 80 +++++++++++++++++++
>>> 1 file changed, 80 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/feature-domains/feature-domain-controller.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/feature-domains/feature-domain-controller.example.dtb: foo@0: feature-domain-names: ['default', 'unbind'] is too long
>> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/feature-domains/feature-domain-controller.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>>
>> See https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ab68324eea3c788a369260f5a1e5da843a960cde.1666806317.git.oleksii_moisieiev@xxxxxxxx/__;!!GF_29dbcQIUBPA!y6dnIrQEa4gr2RDYPf2_Oc7JsKHJrAKtl69xg0Jlf-Qri5BP9kBzqIknprWXaikX5y2Yz_UWCW5yYv_9Hw$ [patchwork[.]ozlabs[.]org]
>>
>> This check can fail if there are any dependencies. The base for a patch
>> series is generally the most recent rc1.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit.
>>
>
> Hello,
>
> Thank you for the response. I would recheck and resubmit patch series if there
> will be no additional comments.
>

when resubmitting, Cc necessary maintainers as pointed out by
scripts/get_maintainer.pl. Or base your tree on something decent...

Best regards,
Krzysztof