Re: [PATCH] thermal: intel: hfi: Improve the type of hfi_features::nr_table_pages

[Rafael J. Wysocki]

On Tue, Oct 18, 2022 at 1:16 PM Ricardo Neri
<ricardo.neri-calderon@xxxxxxxxxxxxxxx> wrote:
>
> A Coverity static code scan raised a potential overflow_before_widen
> warning when hfi_features::nr_table_pages is used as an argument to
> memcpy in intel_hfi_process_event().
>
> Even though the overflow can never happen (the maximum number of pages of
> the HFI table is 0x10 and 0x10 << PAGE_SHIFT = 0x10000), using size_t as
> the data type of hfi_features::nr_table_pages makes Coverity happy and
> matches the data type of the argument 'size' of memcpy().
>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Amit Kucheria <amitk@xxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Len Brown <len.brown@xxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Cc: Aubrey Li <aubrey.li@xxxxxxxxxxxxxxx>
> Cc: Haowen Bai <baihaowen@xxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx>
> ---
>  drivers/thermal/intel/intel_hfi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
> index a0640f762dc5..239afe02e518 100644
> --- a/drivers/thermal/intel/intel_hfi.c
> +++ b/drivers/thermal/intel/intel_hfi.c
> @@ -137,7 +137,7 @@ struct hfi_instance {
>   * Parameters and supported features that are common to all HFI instances
>   */
>  struct hfi_features {
> -       unsigned int    nr_table_pages;
> +       size_t          nr_table_pages;
>         unsigned int    cpu_stride;
>         unsigned int    hdr_size;
>  };
> --

Applied as 6.2 material, thanks!