Re: [PATCH v2 1/2] ASoC: mediatek: dt-bindings: modify machine bindings for two MICs case

From: Krzysztof Kozlowski
Date: Fri Oct 28 2022 - 15:46:03 EST


On 28/10/2022 14:26, Ajye Huang wrote:
> On Sat, Oct 29, 2022 at 1:58 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
>
>>>
>>> + dmic-gpios:
>>> + maxItems: 1
>>> + description: GPIO for switching between DMICs
>>
>> Switching how? Enabling? What is the meaning of each GPIO pin value?
>>
> I think I should add more like an example,
> description: dmic-gpios optional prop for switching between two DMICs.
> Ex, the GPIO can control a MUX HW component to
> select dmic clk and data form a Front or Rear dmic.
>
> Do you agree with that or have other suggestions? If do, I will send
> the v3 patch for you to check, thanks

Sounds better.

Best regards,
Krzysztof