Re: [tip:x86/core] [kallsyms] f138918162: WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert_ratelimited.cold-#[xfs]

From: Peter Zijlstra
Date: Fri Oct 28 2022 - 15:52:28 EST


On Thu, Oct 27, 2022 at 06:51:09PM +0200, Peter Zijlstra wrote:
>
> > However, I noticed that the callsite in the WARNING: message has changed
> > from the usual 'asswarn' (which is the caller of WARN_ON) to
> > 'xfs_buf_alert_ratelimited', which seems totally wrong since XFS log
> > recovery doesn't touch xfs_buf objects at all.
>
> Yeah; and I've meanwhile found more cases where it goes sideways.
>
> I'll revert this patch and try an alternative approach. I'll post
> patches tomorrow or something.

Now posted:

https://lkml.kernel.org/r/20221028194022.388521751@xxxxxxxxxxxxx