Re: [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue capability
From: Bart Van Assche
Date: Fri Oct 28 2022 - 18:09:44 EST
On 10/20/22 11:03, Asutosh Das wrote:
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 36c40210..b740299 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -853,6 +853,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba)
hba->caps |= UFSHCD_CAP_CRYPTO;
hba->caps |= UFSHCD_CAP_AGGR_POWER_COLLAPSE;
hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
+ hba->caps |= UFSHCD_CAP_MCQ_EN;
Shouldn't we have a flag that disables MCQ rather than a flag that
enables MCQ? Otherwise the above line will be duplicated in every single
host controller driver that supports MCQ.
Thanks,
Bart.