Re: [RFC][PATCH v2 20/31] timers: usb: Use del_timer_shutdown() before freeing timer

[Guenter Roeck]

On 10/28/22 13:40, Steven Rostedt wrote:
> On Fri, 28 Oct 2022 12:59:59 -0700
> Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > I'll test again with the following changes on top of your published
> > patch series. I hope this is the current status, but I may have lost
> > something.
> >
> > Looking into it ... deactivate_timer() doesn't do anything
> > and seems wrong. Did I miss something ?
>
> You mean debug_deactivate_timer() or debug_deactivate?

This:

+static void deactivate_timer(struct work_struct *work, bool is_dwork)
+{
+       struct delayed_work *dwork;
+
+       if (!is_dwork)
+               return;
+
+       dwork = to_delayed_work(work);
+}

Guenter