Re: [PATCH] iomap: directly use logical block size

From: Christoph Hellwig
Date: Sun Oct 30 2022 - 04:28:00 EST


On Wed, Oct 26, 2022 at 09:51:33AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@xxxxxxxxxx>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.

This looks reasonable. But given that the blksz variable is only used
once, why not open code the bdev_logical_block_size in the conditional?