Re: [PATCH v4 16/16] x86/mtrr: simplify mtrr_ops initialization

From: Borislav Petkov
Date: Sun Oct 30 2022 - 08:11:32 EST


On Tue, Oct 04, 2022 at 10:10:23AM +0200, Juergen Gross wrote:
> +#ifdef CONFIG_X86_64
> +#define vendor_mtrr_ops(x) NULL
> +#else
> +#define vendor_mtrr_ops(x) &(x)
> +#endif

The idea is good but this is just as hacky.

Just assign the correct one in each branch without this funky ifdeffery.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette