RE: [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue capability

[Avri Altman]

> 
> On 10/20/22 11:03, Asutosh Das wrote:
> > +
> > +     /*
> > +      * This capability allows the host controller driver to turn on/off
> > +      * MCQ mode. MCQ mode may be used to increase performance.
> > +      */
> > +     UFSHCD_CAP_MCQ_EN                               = 1 << 12,
Needs rebase?
UFSHCD_CAP_WB_WITH_CLK_SCALING already occupies that bit.

Thanks,
Avri

> >   };
> 
> I prefer that the above flag would only be introduced after a need
> appears to disable MCQ, e.g. discovery of a host controller that is too
> broken to enable MCQ.
> 
> Since UFSHCI 4.0 controllers must support UFSHCI 3.0, shouldn't users
> have a way to disable MCQ, e.g. via a kernel module parameter?
> 
> Thanks,
> 
> Bart.