Re: [PATCH v2 00/13] staging: r8188eu: clean up action frame handlers

[Philipp Hortmann]

On 10/30/22 19:48, Martin Kaiser wrote:
> Thus wrote Philipp Hortmann (philipp.g.hortmann@xxxxxxxxx):
>
> > On 10/30/22 18:33, Martin Kaiser wrote:
> > > Clean up the handlers for action frames. Summarize common code, remove
> > > unnecessary return values.
>
> > > Please apply this on top of the "remove the last get_da calls" series.
>
> > > Changes in v2
> > > - remove on_action_public's ret variable in patch 3, not in patch 9
>
> > > Martin Kaiser (13):
> > >     staging: r8188eu: replace a GetAddr1Ptr call
> > >     staging: r8188eu: remove duplicate category check
> > >     staging: r8188eu: make on_action_public static void
> > >     staging: r8188eu: make OnAction_back static void
> > >     staging: r8188eu: make OnAction_p2p static void
> > >     staging: r8188eu: remove category check in OnAction_p2p
> > >     staging: r8188eu: replace switch-case with if
> > >     staging: r8188eu: replace GetAddr1Ptr call in OnAction_p2p
> > >     staging: r8188eu: clean up on_action_public
> > >     staging: r8188eu: remove return value from on_action_public_vendor
> > >     staging: r8188eu: remove return value from on_action_public_default
> > >     staging: r8188eu: rtw_action_public_decache's token is a u8
> > >     staging: r8188eu: check destination address in OnAction
>
> > >    drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 116 +++++-------------
> > >    .../staging/r8188eu/include/rtw_mlme_ext.h    |   7 --
> > >    2 files changed, 28 insertions(+), 95 deletions(-)
>
>
> > Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> # Edimax N150
>
> Thanks, Philipp.
>
> I just realized that I forgot to add your Tested-by from the previous
> version. The final code hasn't changed in v2, only the intermediate
> steps were fixed.
>
> Martin

Hi Martin,

thanks for the offer but I prefer to test each new version by myself.

I do trust you a lot but mistakes can always happen.

Bye Philipp