Re: [PATCH] soc: ux500: do not directly dereference __iomem

[Jason A. Donenfeld]

Hi Linus,

On Sun, Oct 23, 2022 at 9:57 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> Sparse reports that calling add_device_randomness() on `uid` is a
> violation of address spaces. And indeed the next usage uses readl()
> properly, but that was left out when passing it toadd_device_
> randomness(). So instead copy the whole thing to the stack first.
>
> Fixes: 4040d10a3d44 ("ARM: ux500: add DB serial number to entropy pool")
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Link: https://lore.kernel.org/all/202210230819.loF90KDh-lkp@xxxxxxxxx/
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Just thought I'd follow up on this.


Jason