RE: [PATCH 1/3] ASoC: adau1372: fix mclk

[Sa, Nuno]

> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@xxxxxxx>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@xxxxxxxxxx>; Sa, Nuno
> <Nuno.Sa@xxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark
> Brown <broonie@xxxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi
> Iwai <tiwai@xxxxxxxx>
> Cc: Maarten Zanders <maarten.zanders@xxxxxxx>; alsa-devel@alsa-
> project.org; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/3] ASoC: adau1372: fix mclk
> 
> [External]
> 
> "mclk" is retrieved from the configuration and assigned to adau1372->clk.
> However adau1372->mclk (==NULL) is used for clk_prepare_enable() and
> clk_disable_unprepare() which don't have any effect.
> 
> Remove .clk from struct adau1372 and use .mclk throughout.
> This change ensures that the input clock is switched on/off when the
> bias level is changed.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders@xxxxxxx>
> ---

I guess this needs a Fixes: tag?

- Nuno Sá