RE: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit

From: Sa, Nuno
Date: Mon Oct 31 2022 - 07:23:50 EST




> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@xxxxxxx>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@xxxxxxxxxx>; Sa, Nuno
> <Nuno.Sa@xxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark
> Brown <broonie@xxxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi
> Iwai <tiwai@xxxxxxxx>
> Cc: Maarten Zanders <maarten.zanders@xxxxxxx>; alsa-devel@alsa-
> project.org; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
>
> [External]
>
> The DAPM control for PGAx uses the PGA mute bit for
> power management. This bit is active high but is set to
> non-inverted (ie when powering, it will mute).
> The ALSA control "PGA x Capture Switch" uses the active
> high PGA_ENx bit, but is set to inverted. So when
> enabling this switch, the PGA gets disabled.
>
> To correct the behaviour, invert both these bits.
>
> Signed-off-by: Maarten Zanders <maarten.zanders@xxxxxxx>
> ---

Also looks like a fix so a Fixes: tag? If so, the patch should come
before ("ASoC: adau1372: add support for S24_LE mode")

- Nuno Sá