Re: [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints
From: Christoph Hellwig
Date: Mon Oct 31 2022 - 08:24:38 EST
On Mon, Oct 31, 2022 at 12:45:20PM +0100, Jiri Slaby (SUSE) wrote:
> Cast the enum members to int when printing them.
>
> Alternatively, we can cast them to ulong (to silence gcc < 12) and use %lu.
> Alternatively, we can move VTIME_PER_SEC away from the enum.
Yes, either split the enum or just use a define. But casts are a big
code smell and should be avoided if there is a reasonable alternative.