Re: [PATCH] x86/cpu: fix undefined behavior in bit shift for intel_detect_tlb

From: Peter Zijlstra
Date: Mon Oct 31 2022 - 08:31:27 EST


On Mon, Oct 31, 2022 at 07:43:40PM +0800, Gaosheng Cui wrote:
> Shifting signed 32-bit value by 31 bits is undefined, so changing
> significant bit to unsigned. The UBSAN warning calltrace like below:
>
> UBSAN: shift-out-of-bounds in arch/x86/kernel/cpu/intel.c:948:21
> left shift of 1 by 31 places cannot be represented in type 'int'

Is it really? Shouldn't -fstrict-overflow define this case?