Re: [PATCH 1/2] mmc: mtk-sd: add Inline Crypto Engine support

[AngeloGioacchino Del Regno]

Il 31/10/22 10:50, Mengqi Zhang (张梦琦) ha scritto:
> On Tue, 2022-10-18 at 11:50 +0200, AngeloGioacchino Del Regno wrote:
> > Il 17/10/22 16:20, Mengqi Zhang ha scritto:
> > > add crypto clock control and ungate it before CQHCI init.
> > >
> > > Signed-off-by: Mengqi Zhang <mengqi.zhang@xxxxxxxxxxxx>
> >
> > Hello Mengqi,
> > I'm a bit surprised that enabling ICE only requires enabling a clock
> > as
> > on downstream code I see some SMC calls to
> > MTK_SIP_KERNEL_HW_FDE_MSDC_CTL.
> >
> > Can you please explain why SMC calls are not needed here?
> >
> > Thanks,
> > Angelo
>
> Hi Angelo,
>
> There are many wrong quotes in previous reply, let me fix it here.
>
> In some MTK SoC, we need set a encrypto enable bit
> MTK_SIP_KERNEL_HW_FDE_MSDC_CTL in secure world, so we use SMC call to
> finish it.
> But not every MTK SoC need to set this bit in secure world. This patch
> is for these SoCs.
> As for SMC call, we haven't found a proper way to deal with it, we'll
> do it later.

Thanks for clarifying.
In that case, I'm a little worried about people trying to enable ICE on SoCs
that do require calling into TZ and getting a crash... but it's anyway out of
scope for this series, so:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>