Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

[Neil Armstrong]

Hi,

On 31/10/2022 16:32, Lee Jones wrote:
> On Fri, 21 Oct 2022, Neil Armstrong wrote:
>
> > The PM8018 compatible is always used with PM8921 fallback, so PM8018
> > compatible can be safely removed from device ID table
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>
> Tags should appear chronologically.

Indeed, they were added by b4, I'll report this.

Thanks,
Neil

> I've fixed this up and applied the patch, thanks.
>
> > ---
> >   drivers/mfd/qcom-pm8xxx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> > index 2f2734ba5273..601106580e2e 100644
> > --- a/drivers/mfd/qcom-pm8xxx.c
> > +++ b/drivers/mfd/qcom-pm8xxx.c
> > @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = {
> >   };
> >   
> >   static const struct of_device_id pm8xxx_id_table[] = {
> > -	{ .compatible = "qcom,pm8018", .data = &pm8xxx_data},
> >   	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
> >   	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
> >   	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},