Re: [PATCH] scsi: BusLogic: remove variable adapter_count

[Khalid Aziz]

On 10/31/22 10:05, Colin Ian King wrote:
> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>   drivers/scsi/BusLogic.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

Looks good to me.

Acked-by: Khalid Aziz <khalid@xxxxxxxxxxxxxx>


> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index f2abffce2659..f7b7ffda1161 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2198,7 +2198,7 @@ static int blogic_slaveconfig(struct scsi_device *dev)
>   
>   static int __init blogic_init(void)
>   {
> -	int adapter_count = 0, drvr_optindex = 0, probeindex;
> +	int drvr_optindex = 0, probeindex;
>   	struct blogic_adapter *adapter;
>   	int ret = 0;
>   
> @@ -2368,10 +2368,8 @@ static int __init blogic_init(void)
>   					list_del(&myadapter->host_list);
>   					scsi_host_put(host);
>   					ret = -ENODEV;
> -				} else {
> +				} else
>   					scsi_scan_host(host);
> -					adapter_count++;
> -				}
>   			}
>   		} else {
>   			/*