RE: [EXT] Re: [PATCH v2 1/1] net: fec: add initial XDP support

[Shenwei Wang]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, October 31, 2022 12:10 PM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> > +                     cbd_base = rxq->bd.base;
> > +                     if (bpf->prog)
> > +                             rxq->bd.ring_size = XDP_RX_RING_SIZE;
> > +                     else
> > +                             rxq->bd.ring_size = RX_RING_SIZE;
> > +                     size = dsize * rxq->bd.ring_size;
> > +                     cbd_base = (struct bufdesc *)(((void *)cbd_base) + size);
> > +                     rxq->bd.last = (struct bufdesc *)(((void
> > + *)cbd_base) - dsize);
> 
> This does not look safe. netif_tx_disable(dev) will stop new transmissions, but
> the hardware can be busy receiving, DMAing frames, using the descriptors, etc.
> Modifying rxq->bd.last in particular seems risky. I think you need to disable the
> receiver, wait for it to indicate it really has stopped, and only then make these
> modifications.
> 

Sounds reasonable. How about moving the codes of updating ring size to the place
right after the enet reset inside the fec_restart? This should clear those risky corner
cases.

Thanks,
Shenwei

>         Andrew