Re: [PATCH net-next V4] net: lan743x: Add support to SGMII register dump for PCI11010/PCI11414 chips

From: Jakub Kicinski
Date: Mon Oct 31 2022 - 19:41:15 EST


On Mon, 31 Oct 2022 12:23:36 +0530 Raju Lakkaraju wrote:
> > You can then read the values in a loop. And inside that loop you can
> > handle errors (perhaps avoiding the need for lan743x_sgmii_dump_read()
> > which seems rather unnecessary as lan743x_sgmii_read() already prints
> > errors).
> >
> > FWIW I like Andrew's suggestion from v3 to use version as a bitfield, too.
>
> I will implement Andrew's suggestion in my next regdump function patch.
> Is it OK ?

SG, thanks!