Re: [RFC PATCH 1/2] dt-bindings: adc-joystick: add valid-range

From: Rob Herring
Date: Mon Oct 31 2022 - 21:08:50 EST


On Mon, Oct 31, 2022 at 05:05:54PM -0500, Rob Herring wrote:
>
> On Mon, 31 Oct 2022 22:01:58 +0300, Siarhei Volkau wrote:
> > The valid-range property aims to cover detachable/lock-able
> > joysticks where measured value goes outside valid-range.
> >
> > Signed-off-by: Siarhei Volkau <lis8215@xxxxxxxxx>
> > ---
> > .../bindings/input/adc-joystick.yaml | 62 +++++++++++++++++++
> > 1 file changed, 62 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/input/adc-joystick.example.dts:82.28-104.11: ERROR (duplicate_label): /example-1/joystick: Duplicate label 'joystick' on /example-1/joystick and /example-0/adc-joystick
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/input/adc-joystick.example.dtb] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1492: dt_binding_check] Error 2

The examples aren't completely independent, so you can't use the same
labels.

Rob