Re: [PATCH 0/5] Parse the PCIE AER structure and set to relevant registers

[LeoLiuoc]

在 2022/10/28 23:15, Bjorn Helgaas 写道:
> On Fri, Oct 28, 2022 at 07:19:25PM +0800, LeoLiuoc wrote:
> > 在 2022/10/27 12:17, Sathyanarayanan Kuppuswamy 写道:
> > > On 10/26/22 8:14 PM, LeoLiu-oc wrote:
>
> > > Can you add spec reference?
> > Please refer to Section 18.3.2 ACPI Error Source of acpi spec v6.3. Links to
> > the online versions of ACPI Spec 6.3 is
> > https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/18_ACPI_Platform_Error_Interfaces/error-source-discovery.html#acpi-error-source.
> >
> > Section 18.3.2.4 describes PCI Express Root Port AER Structure, section
> > 18.3.2.5 describes PCI Express Device AER Structure, section 18.3.2.6
> > describes PCI Express/PCI-X Bridge AER Structure.
>
> Thanks.  It's OK to have the spec references in the email thread, but
> the real point is that they should be in the commit log and, when it
> makes sense, in code comments.
>
> Cite the most recent spec version when you can.  In this case, I think
> it is ACPI r6.5.
>
> Personally I don't really care for URL references because they tend to
> get stale over time as websites are reorganized and domains change.
> Something like "ACPI r6.5, sec 18.3.2.4" is unambiguous and will
> remain usable forever.
>
> Bjorn

Got it. Thanks for your advice. This will be modified in the next version.

Thanks
leoliu-oc