RE: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h

[Ondrej Valousek]

Hi Christoph,
> Well, for that a proper formatted mail really helps.

Yeah for the first main I used Outlook to send, the second email with patch was sent directly using GIT so should be formatted well.
Sorry I am beginner here.

> And these identifiers do not belong into xattr.h.  They are a non-sanctioned NFS side API, not a VFS API.

Ah yes, I forgot about VFS, true. What is the best place to keep them then?
Or is it a big issue to extend VFS with them?
I mean NFSv4 - style ACLs are IMHO even better than Posix ACLs - if not for anything else then because Posix ACLs have never been ratified - maybe we'll see them on local FS at some stage, too.

Thanks,
Ondrej

-----Original Message-----
From: Christoph Hellwig <hch@xxxxxxxxxxxxx> 
Sent: pondělí 31. října 2022 9:03
To: Ondrej Valousek <ondrej.valousek.xm@xxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx; trond.myklebust@xxxxxxxxxxxxxxx; anna@xxxxxxxxxx; Chuck Lever III <chuck.lever@xxxxxxxxxx>
Subject: Re: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h

On Thu, Oct 27, 2022 at 07:43:58AM +0000, Ondrej Valousek wrote:
> Hi kernel maintainers,
> 
> Please help to submit the following patch into kernel

Well, for that a proper formatted mail really helps.

And these identifiers do not belong into xattr.h.  They are a non-sanctioned NFS side API, not a VFS API.