Re: [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD

From: Johan Hovold
Date: Thu Nov 03 2022 - 10:42:22 EST


On Thu, Nov 03, 2022 at 11:41:06PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Nov 03, 2022 at 03:12:32PM +0100, Marek Szyprowski wrote:
> > Force controlling of the generic USB PHYs also from XHCI HCD to let XHCI
> > driver call calibrate() method during the HCD reset. DWC3 also controls
> > USB PHYs, but it is not able to call the calibrate() method at the right
> > moment.
> >
> > Fixes: 6000b8d900cd ("usb: dwc3: disable USB core PHY management")
> > Reported-by: Stefan Agner <stefan@xxxxxxxx>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > ---
> > This fixes the issue reported here:
> > https://lore.kernel.org/all/808bdba846bb60456adf10a3016911ee@xxxxxxxx/
> >
> > Alternative for this change is a complete revert of the 6000b8d900cd
> > ("usb: dwc3: disable USB core PHY management") commit.
>
> We can revert that commit if something is broken so it can be fixed
> properly instead of this.

Yeah, I'll send the revert I've prepared.

Johan