Re: [PATCH 8/8] mm/slub, percpu: correct the calculation of early percpu allocation size

[Baoquan He]

On 11/06/22 at 11:20pm, Dennis Zhou wrote:
> Hi Baoquan,
> 
> On Mon, Nov 07, 2022 at 12:35:56PM +0800, Baoquan He wrote:
> > On 11/06/22 at 09:56pm, Vlastimil Babka wrote:
> > > On 10/24/22 10:14, Baoquan He wrote:
> > > > SLUB allocator relies on percpu allocator to initialize its ->cpu_slab
> > > > during early boot. For that, the dynamic chunk of percpu which serves
> > > > the early allocation need be large enough to satisfy the kmalloc
> > > > creation.
> > > > 
> > > > However, the current BUILD_BUG_ON() in alloc_kmem_cache_cpus() doesn't
> > > > consider the kmalloc array with NR_KMALLOC_TYPES length. Fix that
> > > > with correct calculation.
> > > > 
> > > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
> > > > Cc: Christoph Lameter <cl@xxxxxxxxx>
> > > > Cc: Pekka Enberg <penberg@xxxxxxxxxx>
> > > > Cc: David Rientjes <rientjes@xxxxxxxxxx>
> > > > Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > > Cc: Vlastimil Babka <vbabka@xxxxxxx>
> > > > Cc: Roman Gushchin <roman.gushchin@xxxxxxxxx>
> > > > Cc: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
> > > > ---
> > > >  mm/slub.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > As only slub is touched and there's no prerequsities in the previous
> > > patches, I took this to the slab tree, branch
> > > slab/for-6.2/cleanups
> > 
> > Yes, it only changes slub code. Thanks for taking it.
> > 
> > I will resend v2 with the left 7 percpu only patches with update.
> > 
> > 
> 
> Don't worry about resending them, I'll pick them up tomorrow morning.

That's great. Thanks a lot, Dennis.