Re: [PATCH RFC v3] random: implement getrandom() in vDSO

[Jason A. Donenfeld]

On Tue, Nov 8, 2022 at 9:32 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Fri, Sep 16 2022 at 13:59, Jason A. Donenfeld wrote:
> > ---
> >  MAINTAINERS                            |   2 +
> >  arch/x86/entry/syscalls/syscall_32.tbl |   1 +
> >  arch/x86/entry/syscalls/syscall_64.tbl |   1 +
> >  arch/x86/entry/vdso/Makefile           |   3 +-
> >  arch/x86/entry/vdso/vdso.lds.S         |   2 +
> >  arch/x86/entry/vdso/vgetrandom.c       |  16 ++++
> >  arch/x86/include/asm/vdso/getrandom.h  |  37 ++++++++
> >  arch/x86/include/asm/vvar.h            |  16 ++++
> >  drivers/char/random.c                  |  64 ++++++++++++++
> >  include/vdso/datapage.h                |   6 ++
> >  lib/crypto/chacha.c                    |   4 +
> >  lib/vdso/getrandom.c                   | 117 +++++++++++++++++++++++++
> >  lib/vdso/getrandom.h                   |  25 ++++++
> >  13 files changed, 293 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/x86/entry/vdso/vgetrandom.c
> >  create mode 100644 arch/x86/include/asm/vdso/getrandom.h
> >  create mode 100644 lib/vdso/getrandom.c
> >  create mode 100644 lib/vdso/getrandom.h
>
> This is not how it works. Please split this apart into reviewable bits
> and pieces:
>
> 1) Add the new syscall
> 2) Add the vdso infrastructure
> 3) Wire it up on x86

No problem, will do.

Jason