Re: [PATCH linux-next] selftests/vm: calculate variables in correct order

From: Andrew Morton
Date: Tue Nov 08 2022 - 19:31:31 EST


On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savitz <jsavitz@xxxxxxxxxx> wrote:

> commit b5ba705c2608 ("selftests/vm: enable running select groups of tests")
> unintentionally reversed the ordering of some of the lines of
> run_vmtests.sh that calculate values based on system configuration.
> Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this later
> value is not read from /proc/meminfo until later, causing userfaultfd
> tests to incorrectly fail since $half_ufd_size_MB will always be 0.
>
> Switch these statements around into proper order to fix the invocation
> of the userfaultfd tests that use $half_ufd_size_MB.

Does this fix address the failure in
https://lkml.kernel.org/r/202211021026.61b267d1-yujie.liu@xxxxxxxxx?

Thanks.