RE: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC

[Aakarsh Jain]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
> Sent: 03 November 2022 18:16
> To: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Aakarsh Jain
> <aakarsh.jain@xxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Cc: andrzej.hajda@xxxxxxxxx; mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx;
> ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx;
> benjamin.gaignard@xxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> stanimir.varbanov@xxxxxxxxxx; dillon.minfei@xxxxxxxxx;
> david.plowman@xxxxxxxxxxxxxxx; mark.rutland@xxxxxxx;
> robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; andi@xxxxxxxxxxx;
> alim.akhtar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx;
> pankaj.dubey@xxxxxxxxxxx; smitha.t@xxxxxxxxxxx
> Subject: Re: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7
> hardware for Exynos 3250 SOC
> 
> On 03/11/2022 08:44, Marek Szyprowski wrote:
> > On 03.11.2022 13:35, Krzysztof Kozlowski wrote:
> >> On 02/11/2022 09:06, Aakarsh Jain wrote:
> >>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
> >> Please run scripts/checkpatch.pl and fix reported warnings.
> >>
As I didn't see any checkpatch warnings from the above commit message.
Anyway I fixed all checkpatch warnings from drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c and posted 3 patches for the same.
https://patchwork.kernel.org/project/linux-media/patch/20221109035348.69026-1-aakarsh.jain@xxxxxxxxxxx/

> >>> Exynos3250 and used the same compatible string as used by
> >>> Exynos5240 but both the IPs are a bit different in terms of IP
> >>> clock.
> >>> Lets add variant driver data based on the new compatible string
> >>> "samsung,exynos3250-mfc" for Exynos3250 SoC.
> >> Aren't you just missing the clock on Exynos3250?
> >
> > Nope, the Exynos3250 variant indeed has only one clock and the driver
> > code simply ignored the -ENOENT error while getting the clocks, see
> > the code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it
> > worked fine even without it.
> >
> > IMHO it is a good idea to clean this up.
> 
> OK, then please make the new compatible followed by old.
> 
> Best regards,
> Krzysztof


Thanks for the review.