Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper

[Krzysztof Kozlowski]

On 09/11/2022 08:28, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 00:22, Nícolas F. R. A. Prado wrote:
>> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests
>> on KernelCI, but several of its drivers are currently disabled in the
>> defconfig. This series enables all the missing kconfigs on the defconfig
>> to get everything probing on that machine so that it can be fully tested
>> by KernelCI.
> 
> The changes all look fine, but I would recommend not separating it
> out into 13 patches when you are doing just one thing here. 
> 
> As a general rule, if you keep saying the same things in each
> patch description, it is usually an indication that they should
> be combined. Similarly, if you find describing unrelated changes
> ("also, ..."), that would be an indication that patches should
> be split up.

I agree. Descriptions you wrote are useful - they explain why you are
doing it - but it got all really too detailed, just for defconfigs. One
commit per one symbol is a bit too much...

Best regards,
Krzysztof